libtiff: add patches for multiple CVEs #165872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risicle
added
the
1.severity: security
|
@risicle I think you need to wait for master to be merged into staging. |
vcunat
pushed a commit
that referenced
this pull request
Apr 10, 2022
CVE-2022-0891 CVE-2022-0865 CVE-2022-0924 CVE-2022-0907 CVE-2022-0909 CVE-2022-0908 (cherry picked from commit 748dfdd from PR #165872)
1 task
|
Successfully created backport PR #168133 for |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://nvd.nist.gov/vuln/detail/CVE-2022-0891
https://nvd.nist.gov/vuln/detail/CVE-2022-0865
https://nvd.nist.gov/vuln/detail/CVE-2022-0924
https://nvd.nist.gov/vuln/detail/CVE-2022-0907
https://nvd.nist.gov/vuln/detail/CVE-2022-0909
https://nvd.nist.gov/vuln/detail/CVE-2022-0908
Each tested against the PoC input provided for the issue before and after its respective fix to check its validity.
We're technically not vulnerable to CVE-2022-0865 as it requires jbig2 support, which we don't have enabled. Included the patch anyway for completeness and in case anyone is enabling it via an override (all it takes is adding
jbigkitto thebuildInputs- considered proposing that addition, but it would be a bit of a funny reason to do so - so that we're not missing out on all the vulnerability fun?)As for testing this, don't you think #162110 would make it so much easier to do so?
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes